Commit 5d5053c8 authored by Krzysztof Karas's avatar Krzysztof Karas Committed by Jim Harris
Browse files

nvme_tcp: add PSK to nvme_tcp_ctrlr structure 



Similarly to what we do with PSK identity, add a field
to nvme_tcp_ctrlr structure to hold a generated string
representing PSK. The main purpose of this change is to
prevent PSK from being lost due to allocation on stack
inside nvme_tcp_qpair_connect_sock() function.

Since the key is stored in binary form, additionally,
add a field to hold its size.

Change-Id: I9f9ece51cc0446344d6d038f72714f916a2d3c4d
Signed-off-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17296


Community-CI: Mellanox Build Bot
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent d6b8be84

lib/nvme/nvme_tcp.c

+3 −0
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ 
#include "spdk/string.h"

#include "spdk/trace.h"

#include "spdk/util.h"

#include "spdk/nvmf.h"



#include "spdk_internal/nvme_tcp.h"

#include "spdk_internal/trace_defs.h"
@@ -46,6 +47,8 @@ 
struct nvme_tcp_ctrlr {

	struct spdk_nvme_ctrlr			ctrlr;

	char					psk_identity[NVMF_PSK_IDENTITY_LEN];

	uint8_t					psk[SPDK_TLS_PSK_MAX_LEN];

	int					psk_size;

};



struct nvme_tcp_poll_group {