Commit 5d49baeb authored by Changpeng Liu's avatar Changpeng Liu Committed by Tomasz Zawadzki
Browse files

iscsi: use default MaxRecvDataSegmentLength for login response data length 



Change-Id: I57205143fc29db96761791f2f6a20b4741875d58
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3458


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
parent e1287f7f

lib/iscsi/iscsi.c

+3 −10
Original line number Diff line number Diff line
@@ -1224,7 +1224,6 @@ iscsi_op_login_rsp_init(struct spdk_iscsi_conn *conn, 
{

	struct iscsi_bhs_login_req *reqh;

	struct iscsi_bhs_login_rsp *rsph;

	uint32_t alloc_len;



	rsph = (struct iscsi_bhs_login_rsp *)&rsp_pdu->bhs;

	rsph->opcode = ISCSI_OP_LOGIN_RSP;
@@ -1232,21 +1231,15 @@ iscsi_op_login_rsp_init(struct spdk_iscsi_conn *conn, 
	rsph->status_detail = ISCSI_LOGIN_ACCEPT;

	rsp_pdu->data_segment_len = 0;



	/* Default MaxRecvDataSegmentLength - RFC3720(12.12) */

	if (conn->MaxRecvDataSegmentLength < 8192) {

		alloc_len = 8192;

	} else {

		alloc_len = conn->MaxRecvDataSegmentLength;

	}



	rsp_pdu->data = calloc(1, alloc_len);

	/* The default MaxRecvDataSegmentLength 8192 is used during login. - RFC3720 */

	rsp_pdu->data = calloc(1, 8192);

	if (!rsp_pdu->data) {

		SPDK_ERRLOG("calloc() failed for data segment\n");

		rsph->status_class = ISCSI_CLASS_TARGET_ERROR;

		rsph->status_detail = ISCSI_LOGIN_STATUS_NO_RESOURCES;

		return SPDK_ISCSI_LOGIN_ERROR_RESPONSE;

	}

	rsp_pdu->data_buf_len = alloc_len;

	rsp_pdu->data_buf_len = 8192;



	reqh = (struct iscsi_bhs_login_req *)&pdu->bhs;

	rsph->flags |= (reqh->flags & ISCSI_LOGIN_TRANSIT);