Commit 5b550ae9 authored by Daniel Verkamp's avatar Daniel Verkamp Committed by Jim Harris
Browse files

nvme_spec: update Firmware Slot Info log page 



This was missing the "next reset slot" field, and the revisions were
defined as uint64_t, despite being ASCII strings.

Change-Id: I1f47dab14e0bce317afeefa499ce5e6b518b5c09
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/405824


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 1e3c4c8b

include/spdk/nvme_spec.h

+5 −3
Original line number Diff line number Diff line
@@ -2162,12 +2162,14 @@ SPDK_STATIC_ASSERT(sizeof(union spdk_nvme_feat_host_identifier) == 4, "Incorrect 
 */

struct spdk_nvme_firmware_page {

	struct {

		uint8_t	slot		: 3; /* slot for current FW */

		uint8_t	reserved	: 5;

		uint8_t	active_slot	: 3; /**< Slot for current FW */

		uint8_t	reserved3	: 1;

		uint8_t	next_reset_slot	: 3; /**< Slot that will be active at next controller reset */

		uint8_t	reserved7	: 1;

	} afi;



	uint8_t			reserved[7];

	uint64_t		revision[7]; /* revisions for 7 slots */

	uint8_t			revision[7][8]; /** Revisions for 7 slots (ASCII strings) */

	uint8_t			reserved2[448];

};

SPDK_STATIC_ASSERT(sizeof(struct spdk_nvme_firmware_page) == 512, "Incorrect size");