Commit 5b2687ba authored by Ben Walker's avatar Ben Walker Committed by Jim Harris
Browse files

bdev: Deprecate spdk_bdev_io_get_aux_buf 



I do not believe anything is using this.

Change-Id: I9e09a07df8c1e9af67de4ddffb46f74f8189b1d6
Signed-off-by: default avatarBen Walker <ben@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22310


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
parent 975c1df9

CHANGELOG.md

+5 −0
Original line number Diff line number Diff line
@@ -41,6 +41,11 @@ cores for a given core ID. 
Added public API 'spdk_nvmf_subsystem_set_cntlid_range' to set controller ID

range for a subsystem.



### bdev



`spdk_bdev_io_get_aux_buf` and `spdk_bdev_io_put_aux_buf` are deprecated and

will be removed in the 25.01 release. We do not believe these are in use currently.



### event



The `framework_get_reactors` RPC method supports getting pid and tid.

include/spdk/bdev_module.h

+1 −0
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ 


#include "spdk/bdev.h"

#include "spdk/bdev_zone.h"

#include "spdk/log.h"

#include "spdk/queue.h"

#include "spdk/scsi_spec.h"

#include "spdk/thread.h"

lib/bdev/bdev.c

+11 −0
Original line number Diff line number Diff line
@@ -1443,11 +1443,16 @@ bdev_io_put_buf(struct spdk_bdev_io *bdev_io) 
	bdev_io->internal.f.has_buf = false;

}



SPDK_LOG_DEPRECATION_REGISTER(spdk_bdev_io_put_aux_buf,

			      "spdk_bdev_io_put_aux_buf is deprecated", "v25.01", 0);



void

spdk_bdev_io_put_aux_buf(struct spdk_bdev_io *bdev_io, void *buf)

{

	uint64_t len = bdev_io->u.bdev.num_blocks * bdev_io->bdev->blocklen;



	SPDK_LOG_DEPRECATED(spdk_bdev_io_put_aux_buf);



	assert(buf != NULL);

	_bdev_io_put_buf(bdev_io, buf, len);

}
@@ -1866,11 +1871,17 @@ _bdev_memory_domain_io_get_buf(struct spdk_bdev_io *bdev_io, spdk_bdev_io_get_bu 
	bdev_io_get_buf(bdev_io, len);

}





SPDK_LOG_DEPRECATION_REGISTER(spdk_bdev_io_get_aux_buf,

			      "spdk_bdev_io_get_aux_buf is deprecated", "v25.01", 0);



void

spdk_bdev_io_get_aux_buf(struct spdk_bdev_io *bdev_io, spdk_bdev_io_get_aux_buf_cb cb)

{

	uint64_t len = bdev_io->u.bdev.num_blocks * bdev_io->bdev->blocklen;



	SPDK_LOG_DEPRECATED(spdk_bdev_io_get_aux_buf);



	assert(cb != NULL);

	assert(bdev_io->internal.get_aux_buf_cb == NULL);

	bdev_io->internal.get_aux_buf_cb = cb;