Commit 5a597c6f authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Jim Harris
Browse files

bs_dev: Add notice log when device does not support unmap 



Previously lack of support for specific bdev was not known to user.
This impacts all unmap operations, such as initialization of blobstore.
It should be useful to user to know it will take longer

Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I89bf3bc0342558fda9a8964fb5cb1daa3a8ed79e
Reviewed-on: https://review.gerrithub.io/385999


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 0e004143

lib/blob/bdev/blob_bdev.c

+2 −0
Original line number Diff line number Diff line
@@ -234,6 +234,8 @@ spdk_bdev_create_bs_dev(struct spdk_bdev *bdev, spdk_bdev_remove_cb_t remove_cb, 
		 * This will always work, since bdev implements write_zeroes on top of write

		 * if the device doesn't natively support write_zeroes.

		 */

		SPDK_NOTICELOG("Bdev %s does not support unmap, write_zeroes will be used instead.\n",

			       bdev->name);

		b->bs_dev.unmap = bdev_blob_write_zeroes;

	}