Commit 5a16b8e6 authored by Mateusz Kozlowski's avatar Mateusz Kozlowski Committed by Jim Harris
Browse files

lib/ftl: Segmentation fault fix after write error handling 



Fixed touching NULL write pointer, which would happen after some other
I/O in the same band would receive error and issue its deletion. Any
subsequent write callbacks would then be unable to find and update the
information.

Signed-off-by: default avatarMateusz Kozlowski <mateusz.kozlowski@intel.com>
Change-Id: I07d9791f1b1b673a48356fae55b784c0bf6a6f7a
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462387


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarWojciech Malikowski <wojciech.malikowski@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent eb1ddcb6

lib/ftl/ftl_core.c

+5 −1
Original line number Diff line number Diff line
@@ -1468,8 +1468,12 @@ ftl_io_child_write_cb(struct ftl_io *io, void *ctx, int status) 


	chunk->busy = false;

	chunk->write_offset += io->lbk_cnt;



	/* If some other write on the same band failed the write pointer would already be freed */

	if (spdk_likely(wptr)) {

		wptr->num_outstanding--;

	}

}



static int

ftl_submit_child_write(struct ftl_wptr *wptr, struct ftl_io *io, int lbk_cnt)