Commit 59948022 authored by Michal Berger's avatar Michal Berger Committed by Konrad Sztyber
Browse files

test/coverage: Don't reject coverage under FreeBSD 



It's a bit awkward situation where we reject coverage for freebsd
via the configure step and yet support it in the mk.

Tested coverage collection under freebsd14 using supported lcov
(1.15) - seems to be working just fine.

CI's end still needs to arm FreeBSD with proper tools but staging
tests look promising for now.

Change-Id: Ie09a70cb894d82c1942e0b1d8d6c516a9a8b21d2
Signed-off-by: default avatarMichal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24743


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
parent 6f2b8056

configure

+0 −4
Original line number Diff line number Diff line
@@ -836,10 +836,6 @@ fi 


if [[ $sys_name == "FreeBSD" ]]; then

	# FreeBSD doesn't support all configurations

	if [[ "${CONFIG[COVERAGE]}" == "y" ]]; then

		echo "ERROR: CONFIG_COVERAGE not available on FreeBSD"

		exit 1

	fi

	CONFIG[FSDEV]=n

fi

test/common/autotest_common.sh

+1 −3
Original line number Diff line number Diff line
@@ -477,9 +477,7 @@ function get_config_params() { 
		config_params+=' --enable-asan'

	fi



	if [ "$(uname -s)" = "Linux" ]; then

	config_params+=' --enable-coverage'

	fi



	if [ $SPDK_TEST_BLOBFS -eq 1 ]; then

		if [[ -d /usr/include/fuse3 ]] || [[ -d /usr/local/include/fuse3 ]]; then