Commit 5993fd03 authored by Ivan Efremov's avatar Ivan Efremov Committed by Konrad Sztyber
Browse files

nvmf: Remove the assertion for freeing queued sgroup requests 



During a new subsystem creation we may assign the subsystem_id index
that was previously in use. If we clean requests from previous nvmf subsystem
destruction in the _nvmf_qpair_sgroup_req_clean() but in that time, a new
nvmf_poll_group_add_subsystem() call coming in we may face that some
of the requests still in the queue. The assertion will be fired in this case.

Remove the assertion but leave the log message to notify user about
clearing unhandled requests.

Fixes issue #3467.

Change-Id: I1aa1ea7feac922d94c91a24120810b9f6d3f9c2d
Signed-off-by: default avatarIvan Efremov <i350300800e@gmail.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24648


Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
parent da0454f8

lib/nvmf/nvmf.c

+0 −1
Original line number Diff line number Diff line
@@ -1622,7 +1622,6 @@ nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group, 
				SPDK_ERRLOG("Transport request free error!\n");

			}

		}

		assert(false);

	}



	rc = poll_group_update_subsystem(group, subsystem);