Commit 58898ea3 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Tomasz Zawadzki
Browse files

bdev/nvme: Remove get_admin_qp_failure_reason from qpair_is_connected



For NVMe multipath, if active/passive is used, bdev_nvme_find_io_path()
is rarely called, but if active/active is used, bdev_nvme_find_io_path()
is very frequently called.

If active/passive used, the primary path will be used for a long time.
It may be reasonable to do all possible checks in
nvme_qpair_is_connected().

However, spdk_nvme_ctrlr_get_admin_qp_failure_reason() caused visible
overhead for large scale configuration and small rr_min_io (e.g., 4).

First of all, admin qpair and I/O qpair are independent with each other
and this check was not necessary.

Let's remove spdk_nvme_ctrlr_get_admin_qp_failure_reason() call from
nvme_qpair_is_connected().

Signed-off-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I19591f3befc319c3d1813ba75b2a999f8a24cd62
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20704


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
parent e85b6814
Loading
Loading
Loading
Loading
+0 −5
Original line number Diff line number Diff line
@@ -842,11 +842,6 @@ nvme_qpair_is_connected(struct nvme_qpair *nvme_qpair)
		return false;
	}

	if (spdk_nvme_ctrlr_get_admin_qp_failure_reason(nvme_qpair->ctrlr->ctrlr) !=
	    SPDK_NVME_QPAIR_FAILURE_NONE) {
		return false;
	}

	return true;
}