Commit 585e808e authored by Ziye Yang's avatar Ziye Yang Committed by Tomasz Zawadzki
Browse files

idxd: Remove the batch_op field because it is not necessary. 



This batch_op field is not necessary because we can
use the comp_ctx->desc->opcode to judge whether it is related
a batched task or not.

Change-Id: Id329221ccf272c4c3bb8c1b5ec08433029a9a1f8
Signed-off-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8865


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
parent e3410dd5

lib/idxd/idxd.c

+2 −7
Original line number Diff line number Diff line
@@ -329,8 +329,6 @@ _track_comp(struct spdk_idxd_io_channel *chan, bool batch_op, uint32_t index, 
{

	comp_ctx->desc = desc;

	comp_ctx->index = index;

	/* Tag this as a batched operation or not so we know which bit array index to clear. */

	comp_ctx->batch_op = batch_op;



	/* Only add non-batch completions here.  Batch completions are added when the batch is

	 * submitted.
@@ -1095,13 +1093,10 @@ spdk_idxd_process_events(struct spdk_idxd_io_channel *chan) 
			}



			comp_ctx->hw.status = status = 0;



			if (comp_ctx->batch_op == false) {

			if (comp_ctx->desc->opcode != IDXD_OPCODE_BATCH) {

				assert(spdk_bit_array_get(chan->ring_slots, comp_ctx->index));

				spdk_bit_array_clear(chan->ring_slots, comp_ctx->index);

			}



			if (comp_ctx->desc->opcode == IDXD_OPCODE_BATCH) {

			} else {

				_free_batch(comp_ctx->batch, chan);

			}

		} else {

lib/idxd/idxd.h

+0 −1
Original line number Diff line number Diff line
@@ -160,7 +160,6 @@ struct idxd_comp { 
	struct idxd_hw_desc		*desc;

	uint32_t			*crc_dst;

	uint32_t			index;

	bool				batch_op;

	char				pad[3];

	TAILQ_ENTRY(idxd_comp)		link;

};