Commit 580546d3 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Jim Harris
Browse files

nvme/tcp: simplify acces to qpair in nvme_tcp_req_complete() 



tqpair is already provided as an argument, no need to pick it
out of the tcp_req.
Reduce tqpair->qpair to qpair too.

Change-Id: I9bfa4bce6eaba973e15dd87016461f3e6b780d39
Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@nutanix.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/25797


Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
parent d531f363

lib/nvme/nvme_tcp.c

+5 −5
Original line number Diff line number Diff line
@@ -1010,8 +1010,8 @@ nvme_tcp_req_complete(struct nvme_tcp_req *tcp_req, 


	SPDK_DEBUGLOG(nvme, "complete tcp_req(%p) on tqpair=%p\n", tcp_req, tqpair);



	if (!tcp_req->tqpair->qpair.in_completion_context) {

		tcp_req->tqpair->async_complete++;

	if (!qpair->in_completion_context) {

		tqpair->async_complete++;

	}



	/* Cache arguments to be passed to nvme_complete_request since tcp_req can be zeroed when released */
@@ -1029,10 +1029,10 @@ nvme_tcp_req_complete(struct nvme_tcp_req *tcp_req, 
		}

	}



	tqpair->qpair.queue_depth--;

	qpair->queue_depth--;

	spdk_trace_record(TRACE_NVME_TCP_COMPLETE, qpair->id, 0, (uintptr_t)tcp_req->pdu, req->cb_arg,

			  (uint32_t)req->cmd.cid, (uint32_t)cpl.status_raw, tqpair->qpair.queue_depth);

	TAILQ_REMOVE(&tcp_req->tqpair->outstanding_reqs, tcp_req, link);

			  (uint32_t)req->cmd.cid, (uint32_t)cpl.status_raw, qpair->queue_depth);

	TAILQ_REMOVE(&tqpair->outstanding_reqs, tcp_req, link);

	nvme_tcp_req_put(tqpair, tcp_req);

	nvme_complete_request(req->cb_fn, req->cb_arg, req->qpair, req, &cpl);

}