Commit 56f23848 authored by Changpeng Liu's avatar Changpeng Liu Committed by Tomasz Zawadzki
Browse files

lib/virtio_vfio_user: use VIRTIO_PCI_VRING_ALIGN aligned vring address 



We don't need to allocate 2MiB aligned memory address for
vrings, this will waste memory and may invoke dynamic
memory allocation in DPDK sometimes.

Fix issue #2846.

Change-Id: I6410d417f92623b44c375359d5e2b5ec8ed815c0
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16651


Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 9694127d

lib/virtio/virtio_vfio_user.c

+1 −9
Original line number Diff line number Diff line
@@ -229,15 +229,7 @@ virtio_vfio_user_setup_queue(struct virtio_dev *vdev, struct virtqueue *vq) 
	uint64_t queue_mem_phys_addr;

	int rc;



	/* To ensure physical address contiguity we make the queue occupy

	 * only a single hugepage (2MB). As of Virtio 1.0, the queue size

	 * always falls within this limit.

	 */

	if (vq->vq_ring_size > VALUE_2MB) {

		return -ENOMEM;

	}



	queue_mem = spdk_zmalloc(vq->vq_ring_size, VALUE_2MB, NULL,

	queue_mem = spdk_zmalloc(vq->vq_ring_size, VIRTIO_PCI_VRING_ALIGN, NULL,

				 SPDK_ENV_LCORE_ID_ANY, SPDK_MALLOC_DMA);

	if (queue_mem == NULL) {

		return -ENOMEM;