Commit 56ad1cbe authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

ut/lvol: remove bogus lvol_op_comp test 



This is passing a struct lvol_task that is not nested inside a bdev_io
context, which is assumed by lvol_op_comp() in the actual lvol code.

There is no problem currently, since lvol_op_comp() happens to not
dereference the bdev_io except inside of mocked functions and inside a
SPDK_INFOLOG() that does not get executed in the unit tests right now,
but this would break if the lvol code ever actually used the bdev_io
pointer.

Change-Id: Ic3b67f4ecff47e5a98a5be8a83c2524573113aa9
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/418735


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 2e0df781

test/unit/lib/bdev/vbdev_lvol.c/vbdev_lvol_ut.c

+0 −10
Original line number Diff line number Diff line
@@ -1330,15 +1330,6 @@ ut_vbdev_lvol_io_type_supported(void) 
	free(lvol);

}



static void

ut_lvol_op_comp(void)

{

	struct lvol_task task;



	lvol_op_comp(&task, 1);

	CU_ASSERT(task.status == SPDK_BDEV_IO_STATUS_FAILED);

}



static void

ut_lvol_read_write(void)

{
@@ -1468,7 +1459,6 @@ int main(int argc, char **argv) 
		CU_add_test(suite, "lvol_hotremove", ut_lvol_hotremove) == NULL ||

		CU_add_test(suite, "ut_vbdev_lvol_get_io_channel", ut_vbdev_lvol_get_io_channel) == NULL ||

		CU_add_test(suite, "ut_vbdev_lvol_io_type_supported", ut_vbdev_lvol_io_type_supported) == NULL ||

		CU_add_test(suite, "ut_lvol_op_comp", ut_lvol_op_comp) == NULL ||

		CU_add_test(suite, "ut_lvol_read_write", ut_lvol_read_write) == NULL ||

		CU_add_test(suite, "ut_vbdev_lvol_submit_request", ut_vbdev_lvol_submit_request) == NULL ||

		CU_add_test(suite, "lvol_examine", ut_lvol_examine) == NULL ||