Commit 565932d2 authored Apr 09, 2018 by Daniel Verkamp

nvmf: fix non-deallocate Dataset Management status



If the host sends a Dataset Management command that does not specify the
Deallocate attribute, the NVMe-oF target should return success; the spec
says that this command is advisory, and all combinations of attributes
may be set.

Change-Id: I5d87d93ec61d27c8d65a17bbe4accc12ba26bbd3
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/406995


Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent 2a3d7bf3

lib/nvmf/ctrlr_bdev.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -371,7 +371,8 @@ nvmf_bdev_ctrlr_dsm_cmd(struct spdk_bdev bdev, struct spdk_bdev_desc desc,
		return SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS;
		}

		response->status.sc = SPDK_NVME_SC_INTERNAL_DEVICE_ERROR;
		response->status.sct = SPDK_NVME_SCT_GENERIC;
		response->status.sc = SPDK_NVME_SC_SUCCESS;
		return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;
		}