Commit 552898ec authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

nvme_qpair: fail the ctrlr only for errors on admin qpair. 



We shouldn't always fail the whole controller if we get a failure on an
individual qpair.

Change-Id: Id0c90af83e5231593a895be66e7a7de48939e240
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/471660


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarAlexey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 6b314fb5

lib/nvme/nvme_qpair.c

+3 −1
Original line number Diff line number Diff line
@@ -471,8 +471,10 @@ spdk_nvme_qpair_process_completions(struct spdk_nvme_qpair *qpair, uint32_t max_ 
	ret = nvme_transport_qpair_process_completions(qpair, max_completions);

	if (ret < 0) {

		SPDK_ERRLOG("CQ error, abort requests after transport retry counter exceeded\n");

		if (nvme_qpair_is_admin_queue(qpair)) {

			nvme_ctrlr_fail(qpair->ctrlr, false);

		}

	}

	qpair->in_completion_context = 0;

	if (qpair->delete_after_completion_context) {

		/*