Commit 54f59263 authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

vhost/scsi: handle spdk_vhost_gpa_to_vva() failure 



One call to spdk_vhost_gpa_to_vva() was missing a return code check.

Change-Id: I3581ade98f7fbf72419f8216718a17de50bac4b7
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/408759


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Reviewed-by: default avatarPawel Wodkowski <pawelx.wodkowski@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 9c7d842c

lib/vhost/vhost_scsi.c

+5 −0
Original line number Diff line number Diff line
@@ -326,6 +326,11 @@ process_ctrl_request(struct spdk_vhost_scsi_task *task) 
	}



	ctrl_req = spdk_vhost_gpa_to_vva(vdev, desc->addr, sizeof(*ctrl_req));

	if (ctrl_req == NULL) {

		SPDK_ERRLOG("%s: Invalid task management request at index %d.\n",

			    vdev->name, task->req_idx);

		goto out;

	}



	SPDK_DEBUGLOG(SPDK_LOG_VHOST_SCSI_QUEUE,

		      "Processing controlq descriptor: desc %d/%p, desc_addr %p, len %d, flags %d, last_used_idx %d; kickfd %d; size %d\n",