Commit 54cfee2e authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

iscsi: replace magic numbers with SCSI constants 



Change-Id: I9b33b038a019576d162c868e2021db1c6589b4f4
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/362061


Tested-by: default avatar <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent afbb5cee

lib/iscsi/iscsi.c

+6 −6
Original line number Diff line number Diff line
@@ -3285,12 +3285,12 @@ spdk_iscsi_op_task(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *pdu) 
		return SPDK_SUCCESS;



	case ISCSI_TASK_FUNC_CLEAR_TASK_SET:

		task->scsi.response = 5; /* not supported. */

		task->scsi.response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;

		SPDK_NOTICELOG("CLEAR_TASK_SET (Unsupported)\n");

		break;



	case ISCSI_TASK_FUNC_CLEAR_ACA:

		task->scsi.response = 5; /* not supported. */

		task->scsi.response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;

		SPDK_NOTICELOG("CLEAR_ACA (Unsupported)\n");

		break;
@@ -3310,7 +3310,7 @@ spdk_iscsi_op_task(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *pdu) 
		if (rc < 0)

			SPDK_ERRLOG("tgt_node reset failed\n");

#else

		task->scsi.response = 5; /* not supported */

		task->scsi.response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;

#endif

		break;
@@ -3326,18 +3326,18 @@ spdk_iscsi_op_task(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *pdu) 


		conn->state = ISCSI_CONN_STATE_EXITING;

#else

		task->scsi.response = 5; /* not supported */

		task->scsi.response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;

#endif

		break;



	case ISCSI_TASK_FUNC_TASK_REASSIGN:

		SPDK_NOTICELOG("TASK_REASSIGN (Unsupported)\n");

		task->scsi.response = 5; /* not supported */

		task->scsi.response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;

		break;



	default:

		SPDK_ERRLOG("unsupported function %d\n", function);

		task->scsi.response = 255; /* Function rejected. */

		task->scsi.response = SPDK_SCSI_TASK_MGMT_RESP_REJECT;

		break;

	}