Commit 54944c1d authored Apr 15, 2024 by Jim Harris Committed by Tomasz Zawadzki Apr 17, 2024

event: don't NOTICELOG when no RPC server started



This message will be confusing to new users - so make it a DEBUGLOG
instead.

If user specified an RPC listen address that cannot be opened, we
will exit with error now, so this message should just be removed.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I17d57ce0cca6d82ef9b883a99041a0c3f87a59d9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22814


Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot

parent 460a2e39

lib/event/app.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -354,7 +354,7 @@ app_do_spdk_subsystem_init(int rc, void *arg1)
		}
		spdk_rpc_server_pause(g_spdk_app.rpc_addr);
		} else {
		SPDK_NOTICELOG("RPC server not started\n");
		SPDK_DEBUGLOG(app_rpc, "RPC server not started\n");
		}
		spdk_subsystem_init(app_subsystem_init_done, NULL);
		}

test/unit/lib/event/app.c/app_ut.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -39,6 +39,8 @@ DEFINE_STUB(spdk_reactors_init, int, (size_t msg_mempool_size), 0);
		DEFINE_STUB_V(spdk_reactors_fini, (void));
		bool g_scheduling_in_progress;

		SPDK_LOG_REGISTER_COMPONENT(app_rpc);

		static void
		unittest_usage(void)
		{

Admin message