Commit 546a1148 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Jim Harris
Browse files

test/iscsi: Change the order of delete_bdev to fix nightly test failure. 



By the following change, delete bdev operation will wait until all
related iSCSI connections exit.

    scsi: Don't free IO channel at LUN removal not by allocator

Hence delete bdev must be called after iscsicleanup in test code.

The following patch tried to do that. However nightly test code was
missed to change.

    test/iscsi: Change the order of delete_bdev that hides uncorrect
    hotplug implementation.

This patch fixes the failure of nightly test. By this patch passing
iSCSI nightly test was verified.

Change-Id: Ia3ac234db6d569212de9234b7201b132236b5993
Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/417376


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent f04277f0

test/iscsi_tgt/ext4test/ext4test.sh

+1 −2
Original line number Diff line number Diff line
@@ -113,12 +113,11 @@ for dev in $devs; do 
	echo ""

done



$rpc_py delete_error_bdev EE_Malloc0



trap - SIGINT SIGTERM EXIT



rm -f $testdir/iscsi.conf

iscsicleanup

$rpc_py delete_error_bdev EE_Malloc0

killprocess $pid

report_test_completion "nightly_iscsi_ext4test"

timing_exit ext4test