Commit 543cb172 authored Dec 11, 2017 by Daniel Verkamp Committed by Jim Harris Jan 03, 2018

build: remove $(ENV_CFLAGS) where not necessary



Only Makefiles for libraries that directly depend on DPDK (rather than
the SPDK env abstraction) should add $(ENV_CFLAGS).

Change-Id: Ifdf44d3ef8c42bbf7f20edd524b330d00658235b
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/392818


Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent 61c14937

app/iscsi_tgt/Makefile

+0 −2

Original line number	Diff line number	Diff line
		@@ -38,8 +38,6 @@ include $(SPDK_ROOT_DIR)/mk/spdk.modules.mk

		APP = iscsi_tgt

		CFLAGS += $(ENV_CFLAGS)

		# Add iSCSI library directory to include path
		# TODO: remove this once iSCSI has a public API header
		CFLAGS += -I$(SPDK_ROOT_DIR)/lib

app/nvmf_tgt/Makefile

+0 −2

Original line number	Diff line number	Diff line
		@@ -38,8 +38,6 @@ include $(SPDK_ROOT_DIR)/mk/spdk.modules.mk

		APP = nvmf_tgt

		CFLAGS += $(ENV_CFLAGS)

		C_SRCS := conf.c nvmf_main.c nvmf_tgt.c nvmf_rpc.c

		SPDK_LIB_LIST = event_bdev event_copy

app/trace/Makefile

+0 −1

Original line number	Diff line number	Diff line
		@@ -35,7 +35,6 @@ SPDK_ROOT_DIR := $(abspath $(CURDIR)/../..)
		include $(SPDK_ROOT_DIR)/mk/spdk.common.mk
		include $(SPDK_ROOT_DIR)/mk/spdk.app.mk

		CXXFLAGS += $(ENV_CFLAGS)
		CXX_SRCS := trace.cpp

		APP = spdk_trace

app/vhost/Makefile

+0 −2

Original line number	Diff line number	Diff line
		@@ -38,8 +38,6 @@ include $(SPDK_ROOT_DIR)/mk/spdk.modules.mk

		APP = vhost

		CFLAGS += $(ENV_CFLAGS)

		C_SRCS := vhost.c

		SPDK_LIB_LIST = event_bdev event_copy event_net event_scsi event_vhost

examples/bdev/fio_plugin/Makefile

+1 −1

Original line number	Diff line number	Diff line
		@@ -40,7 +40,7 @@ include $(SPDK_ROOT_DIR)/mk/spdk.modules.mk
		APP := fio_plugin

		C_SRCS = fio_plugin.c
		CFLAGS += -I. $(ENV_CFLAGS) -I$(FIO_SOURCE_DIR)
		CFLAGS += -I$(FIO_SOURCE_DIR)
		LDFLAGS += -shared -rdynamic

		SPDK_LIB_LIST += util bdev conf copy rpc jsonrpc json log