Commit 53447f06 authored May 07, 2021 by Jim Harris Committed by Tomasz Zawadzki May 11, 2021

nvmf: remove a bdev_module.h #include



ctrlr_discovery.c doesn't need this #include.
Including it causes bdev_module.h types to be
emitted to the debug symbols at least with some
compilers, which can result in unwanted abidiff
errors.

The unit tests do need it, so just include it
there instead.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Iad28f9778ce08b11b52325658583ae9032295f3a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7813


Community-CI: Broadcom CI
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Michal Berger <michalx.berger@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>

parent 8a12e2e7

lib/nvmf/ctrlr_discovery.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -44,7 +44,6 @@
		#include "spdk/trace.h"
		#include "spdk/nvmf_spec.h"

		#include "spdk/bdev_module.h"
		#include "spdk/log.h"

		void

test/unit/lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -37,6 +37,7 @@
		#include "spdk_internal/mock.h"

		#include "common/lib/test_env.c"
		#include "spdk/bdev_module.h"
		#include "nvmf/ctrlr_discovery.c"
		#include "nvmf/subsystem.c"

Admin message