Commit 53011dca authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

test/nvme: add more timeouts to nvme_rpc_timeouts 



While doing so we need to pick some value. Picked max valid value
(yet another implicit test) and adjusted previously defined timeout
values to that.

Unfortunately python argparse doesn't support numbers in hex by default.

Change-Id: I67c0f73d5b2cd0259ec3d9872a8df48de5dfcf46
Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/25939


Reviewed-by: default avatarMichal Berger <michal.berger@nutanix.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
parent 0b8d2443

test/nvme/nvme_rpc_timeouts.sh

+23 −4
Original line number Diff line number Diff line
@@ -6,7 +6,6 @@ 
## Test goal: Confirm that rpc setting of bdev_nvme_set_options timeout values is working

## Test steps:

# 1. Run the target with default settings, and use "rpc.py save_config" to check them.

#    Defaults are:  action_on_timeout=none, timeout_us=0, and timeout_admin_us=0

# 2. Use "rpc.py bdev_nvme_set_options" to set the timeout values. Capture the

#    modified settings using save_config.

# 3. Compare the default settings to the modified settings to make sure they got changed.
@@ -30,12 +29,32 @@ echo Checking default timeout settings: 
$rpc_py save_config > $tmpfile_default_settings



echo Making settings changes with rpc:

# Set action_on_timeout, timeout_us, and timeout_admin_us to non-default values

$rpc_py bdev_nvme_set_options --timeout-us=12000000 --timeout-admin-us=24000000 --action-on-timeout=abort

# Set timeouts to non-default values

$rpc_py bdev_nvme_set_options \

	--action-on-timeout=abort \

	--keep-alive-timeout-ms=4294967295 \

	--timeout-us=18446744073709551615 \

	--timeout-admin-us=18446744073709551615 \

	--ctrlr-loss-timeout-sec=2147483647 \

	--reconnect-delay-sec=2147483647 \

	--fast-io-fail-timeout-sec=2147483647 \

	--transport-ack-timeout=255 \

	--rdma-cm-event-timeout-ms=65535 \

	--tcp-connect-timeout-ms=2147483647



echo Check default vs. modified settings:

$rpc_py save_config > $tmpfile_modified_settings

settings_to_check="action_on_timeout timeout_us timeout_admin_us"

settings_to_check="

	action_on_timeout

	keep_alive_timeout_ms

	timeout_us

	timeout_admin_us

	ctrlr_loss_timeout_sec

	reconnect_delay_sec

	fast_io_fail_timeout_sec

	transport_ack_timeout

	rdma_cm_event_timeout_ms

	tcp_connect_timeout_ms"

for setting in $settings_to_check; do

	setting_before=$(grep ${setting} ${tmpfile_default_settings} | awk '{print $2}' | sed 's/[^a-zA-Z0-9]//g')

	setting_modified=$(grep ${setting} ${tmpfile_modified_settings} | awk '{print $2}' | sed 's/[^a-zA-Z0-9]//g')