Commit 5206698e authored by Ziye Yang's avatar Ziye Yang Committed by Tomasz Zawadzki
Browse files

nvme/tcp: Add the implementation to get the optimal polling group 



Add the real support in nvme tcp transport.

Change-Id: I2aa9b0284d6fe009925e67f602a055e787f77987
Signed-off-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5734


Community-CI: Broadcom CI
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent e749b5d3

lib/nvme/nvme_tcp.c

+16 −0
Original line number Diff line number Diff line
@@ -1956,6 +1956,21 @@ nvme_tcp_poll_group_create(void) 
	return &group->group;

}



static struct spdk_nvme_transport_poll_group *

nvme_tcp_qpair_get_optimal_poll_group(struct spdk_nvme_qpair *qpair)

{

	struct nvme_tcp_qpair *tqpair = nvme_tcp_qpair(qpair);

	struct spdk_sock_group *group = NULL;

	int rc;



	rc = spdk_sock_get_optimal_sock_group(tqpair->sock, &group);

	if (!rc && group != NULL) {

		return spdk_sock_group_get_ctx(group);

	}



	return NULL;

}



static int

nvme_tcp_poll_group_connect_qpair(struct spdk_nvme_qpair *qpair)

{
@@ -2079,6 +2094,7 @@ const struct spdk_nvme_transport_ops tcp_ops = { 
	.admin_qpair_abort_aers = nvme_tcp_admin_qpair_abort_aers,



	.poll_group_create = nvme_tcp_poll_group_create,

	.qpair_get_optimal_poll_group = nvme_tcp_qpair_get_optimal_poll_group,

	.poll_group_connect_qpair = nvme_tcp_poll_group_connect_qpair,

	.poll_group_disconnect_qpair = nvme_tcp_poll_group_disconnect_qpair,

	.poll_group_add = nvme_tcp_poll_group_add,

test/unit/lib/nvme/nvme_tcp.c/nvme_tcp_ut.c

+9 −0
Original line number Diff line number Diff line
@@ -50,6 +50,15 @@ DEFINE_STUB(spdk_sock_set_priority, 


DEFINE_STUB(spdk_nvme_poll_group_remove, int, (struct spdk_nvme_poll_group *group,

		struct spdk_nvme_qpair *qpair), 0);

DEFINE_STUB(spdk_sock_get_optimal_sock_group,

	    int,

	    (struct spdk_sock *sock, struct spdk_sock_group **group),

	    0);



DEFINE_STUB(spdk_sock_group_get_ctx,

	    void *,

	    (struct spdk_sock_group *group),

	    NULL);



DEFINE_STUB(spdk_nvme_poll_group_process_completions, int64_t, (struct spdk_nvme_poll_group *group,

		uint32_t completions_per_qpair, spdk_nvme_disconnected_qpair_cb disconnected_qpair_cb), 0);