Commit 51bc5fce authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

nvmf: drop redundant response CID assignments 



spdk_nvmf_request_complete() always sets CID to the value in the
command, so there is no need to set it in the command execution
functions.

Change-Id: Ibbe745b862e27fff7c55e553758ef093e3ef7f6d
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
parent 13c65342

lib/nvmf/request.c

+0 −3
Original line number Diff line number Diff line
@@ -78,7 +78,6 @@ nvmf_process_discovery_cmd(struct spdk_nvmf_request *req) 


	/* pre-set response details for this command */

	response->status.sc = SPDK_NVME_SC_SUCCESS;

	response->cid = cmd->cid;



	if (req->data == NULL) {

		SPDK_ERRLOG("discovery command with no buffer\n");
@@ -151,7 +150,6 @@ nvmf_process_admin_cmd(struct spdk_nvmf_request *req) 


	/* pre-set response details for this command */

	response->status.sc = SPDK_NVME_SC_SUCCESS;

	response->cid = cmd->cid;



	switch (cmd->opc) {

	case SPDK_NVME_OPC_IDENTIFY:
@@ -266,7 +264,6 @@ nvmf_process_io_cmd(struct spdk_nvmf_request *req) 
	/* pre-set response details for this command */

	response = &req->rsp->nvme_cpl;

	response->status.sc = SPDK_NVME_SC_SUCCESS;

	response->cid = cmd->cid;



	/* verify that the contoller is ready to process commands */

	if (session->vcprop.csts.bits.rdy == 0) {