Commit 5172337d authored by Niklas Cassel's avatar Niklas Cassel Committed by Tomasz Zawadzki
Browse files

nvme/fio_plugin: spdk_fio_get_zoned_model() is too permissive 



The .get_zoned_model() callback is supposed to reject unsupported
file types. Right now, we only reject FIO_TYPE_PIPE.

However, in attach_cb() our ioengine unconditionally initializes
f->filetype to FIO_TYPE_BLOCK. This means that the only file type
that our ioengine supports is FIO_TYPE_BLOCK.

Therefore, fix spdk_get_zoned_model() to reject everything that
we do not support.

Signed-off-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Change-Id: I115bb8ff9c8ea9f647baebc0196900681a36c410
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8327


Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent bd53d09c

examples/nvme/fio_plugin/fio_plugin.c

+1 −3
Original line number Diff line number Diff line
@@ -1153,9 +1153,7 @@ spdk_fio_get_zoned_model(struct thread_data *td, struct fio_file *f, enum zbd_zo 
	struct spdk_fio_qpair *fio_qpair = NULL;

	const struct spdk_nvme_zns_ns_data *zns_data = NULL;



	if (f->filetype != FIO_TYPE_FILE && \

	    f->filetype != FIO_TYPE_BLOCK && \

	    f->filetype != FIO_TYPE_CHAR) {

	if (f->filetype != FIO_TYPE_BLOCK) {

		log_info("spdk/nvme: unsupported filetype: %d\n", f->filetype);

		return -EINVAL;

	}