Commit 50f90bc9 authored by Konrad Sztyber's avatar Konrad Sztyber
Browse files

nvmf: remove spdk_nvmf_request_exec_fabrics() 



It was deprecated and was supposed to be removed in the upcoming
release.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I6fdd94160fade6b0a5820304bce5c24f69641e3a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24804


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
parent e43b1b86

deprecation.md

+0 −6
Original line number Diff line number Diff line
@@ -29,12 +29,6 @@ in `spdk_nvme_ctrlr_opts.tls_psk`. 


### nvmf



#### `spdk_nvmf_request_exec_fabrics`



This function is deprecated and will be removed in the 24.09 release.  Instead, users should use

`spdk_nvmf_request_exec()`, which now allows all transports (both fabrics and non-fabrics) to

execute fabrics commands.



#### `nvmf_subsystem_add_host`



The ability to specifying path to a PSK file via the `psk` parameter in `nvmf_subsystem_add_host` is

include/spdk/nvmf_transport.h

+0 −1
Original line number Diff line number Diff line
@@ -549,7 +549,6 @@ int spdk_nvmf_request_get_buffers(struct spdk_nvmf_request *req, 
bool spdk_nvmf_request_get_dif_ctx(struct spdk_nvmf_request *req, struct spdk_dif_ctx *dif_ctx);



void spdk_nvmf_request_exec(struct spdk_nvmf_request *req);

void spdk_nvmf_request_exec_fabrics(struct spdk_nvmf_request *req);

int spdk_nvmf_request_free(struct spdk_nvmf_request *req);

int spdk_nvmf_request_complete(struct spdk_nvmf_request *req);

void spdk_nvmf_request_zcopy_start(struct spdk_nvmf_request *req);

lib/nvmf/ctrlr.c

+0 −10
Original line number Diff line number Diff line
@@ -4759,16 +4759,6 @@ spdk_nvmf_request_complete(struct spdk_nvmf_request *req) 
	return 0;

}



SPDK_LOG_DEPRECATION_REGISTER(nvmf_request_exec_fabrics, "spdk_nvmf_request_exec_fabrics()",

			      "v24.09", 1);

void

spdk_nvmf_request_exec_fabrics(struct spdk_nvmf_request *req)

{

	SPDK_LOG_DEPRECATED(nvmf_request_exec_fabrics);



	return spdk_nvmf_request_exec(req);

}



static bool

nvmf_check_subsystem_active(struct spdk_nvmf_request *req)

{

lib/nvmf/spdk_nvmf.map

+0 −1
Original line number Diff line number Diff line
@@ -125,7 +125,6 @@ 
	spdk_nvmf_request_free_buffers;

	spdk_nvmf_request_get_buffers;

	spdk_nvmf_request_get_dif_ctx;

	spdk_nvmf_request_exec_fabrics;

	spdk_nvmf_request_exec;

	spdk_nvmf_request_free;

	spdk_nvmf_request_complete;