Commit 4faa7b58 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki
Browse files

test: remove RUN_NIGHTLY_FAILING flag 



Purpose of this flag is sketchy at best.
Failing tests should be either fixed or disabled/removed.
Running separate job in hopes of it fixing itself,
might not bring the expected outcome.

Case in point - test case in this patch
was added to this flag over a year ago.

This is last remaining test case under this flag.
So there is no need for it to exist.

Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I8481ac7102245889047dde083b34276d22271a03
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1495


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 7c1e69b3

test/bdev/blockdev.sh

+1 −7
Original line number Diff line number Diff line
@@ -192,13 +192,7 @@ function fio_test_suite() { 
		echo "filename=$b" >> $testdir/bdev.fio

	done



	if [ $RUN_NIGHTLY_FAILING -eq 0 ]; then

	local fio_params="--ioengine=spdk_bdev --iodepth=8 --bs=4k --runtime=10 $testdir/bdev.fio --spdk_json_conf=$conf_file"

	else

		# Use size 192KB which both exceeds typical 128KB max NVMe I/O

		#  size and will cross 128KB Intel DC P3700 stripe boundaries.

		local fio_params="--ioengine=spdk_bdev --iodepth=128 --bs=192k --runtime=100 $testdir/bdev.fio --spdk_json_conf=$conf_file"

	fi



	run_test "bdev_fio_rw_verify" fio_bdev $fio_params --spdk_mem=$PRE_RESERVED_MEM \

	--output=$output_dir/blockdev_fio_verify.txt

test/common/autotest_common.sh

+0 −3
Original line number Diff line number Diff line
@@ -54,9 +54,6 @@ fi' 
: ${RUN_NIGHTLY:=0}

export RUN_NIGHTLY



: ${RUN_NIGHTLY_FAILING:=0}

export RUN_NIGHTLY_FAILING



# Set defaults for missing test config options

: ${SPDK_AUTOTEST_DEBUG_APPS:=0}; export SPDK_AUTOTEST_DEBUG_APPS

: ${SPDK_BUILD_PACKAGE=0}; export SPDK_BUILD_PACKAGE