Commit 4f4d0ab6 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Tomasz Zawadzki
Browse files

lib/iscsi: Remove workaround for astyle format check about break-after-return-type 



To avoid the strange formatting, typedef has been used. But this
comment is hard to get the meaning. So stop breaking after return
type for this case.

Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: I317604de67aab9f201d691e0f886bd673f451f3f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1051


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 63836029

lib/iscsi/tgt_node.c

+7 −8
Original line number Diff line number Diff line
@@ -917,8 +917,7 @@ spdk_iscsi_check_chap_params(bool disable, bool require, bool mutual, int group) 
	return false;

}



_spdk_iscsi_tgt_node *

spdk_iscsi_tgt_node_construct(int target_index,

struct spdk_iscsi_tgt_node *spdk_iscsi_tgt_node_construct(int target_index,

		const char *name, const char *alias,

		int *pg_tag_list, int *ig_tag_list, uint16_t num_maps,

		const char *bdev_name_list[], int *lun_id_list, int num_luns,

lib/iscsi/tgt_node.h

+7 −13
Original line number Diff line number Diff line
@@ -105,19 +105,13 @@ int spdk_iscsi_send_tgts(struct spdk_iscsi_conn *conn, const char *iiqn, 
			 const char *iaddr, const char *tiqn, uint8_t *data, int alloc_len,

			 int data_len);



/* This typedef exists to work around an astyle 2.05 bug.

 * Remove it when astyle is fixed.

 */

typedef struct spdk_iscsi_tgt_node _spdk_iscsi_tgt_node;



/*

 * bdev_name_list and lun_id_list are equal sized arrays of size num_luns.

 * bdev_name_list refers to the names of the bdevs that will be used for the LUNs on the

 *  new target node.

 * lun_id_list refers to the LUN IDs that will be used for the LUNs on the target node.

 */

_spdk_iscsi_tgt_node *

spdk_iscsi_tgt_node_construct(int target_index,

struct spdk_iscsi_tgt_node *spdk_iscsi_tgt_node_construct(int target_index,

		const char *name, const char *alias,

		int *pg_tag_list, int *ig_tag_list, uint16_t num_maps,

		const char *bdev_name_list[], int *lun_id_list, int num_luns,