Commit 4e3cc6e1 authored by Ben Walker's avatar Ben Walker Committed by Jim Harris
Browse files

nvmf: Change max_delay_us to 0



This sets the maximum tolerated additional latency
on an I/O, which potentially allows a thread to
sleep and save power. However, today if a poller
is registered on the thread it will never sleep,
which is always true for the nvmf_tgt.

Further, if this were fixed such that the thread could
sleep as long as the pollers all reported idle, this
max latency ends up breaking the QoS test because the
service provided is more than 10% away from the target
number.

Change-Id: Ic9decbd92ad4e0c19eb81eea18a59207d6028367
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/432497


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarPiotr Pelpliński <piotr.pelplinski@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 9ba446a2
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ main(int argc, char **argv)
	/* default value in opts */
	spdk_app_opts_init(&opts);
	opts.name = "nvmf";
	opts.max_delay_us = 1000; /* 1 ms */
	opts.max_delay_us = 0;
	if ((rc = spdk_app_parse_args(argc, argv, &opts, "", NULL,
				      nvmf_parse_arg, nvmf_usage)) !=
	    SPDK_APP_PARSE_ARGS_SUCCESS) {