Commit 4d566944 authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

bdev/nvme: make ROUND_ROBIN the default multipath policy for active/active 



ROUND_ROBIN should be the default, but the patch that added the QUEUE_DEPTH
selector accidentally broke this.

The net effect would be that the selector would be set to 0 which is not
a valid enum value, but would end up acting like QUEUE_DEPTH selector since
the critical decision compares the selector with ROUND_ROBIN.

Fixes issue #3338.
Fixes: 6aa4edc2 ("bdev/nvme: select io path according to outstanding io numbder")
Signed-off-by: default avatarJim Harris <jim.harris@samsung.com>
Change-Id: I930a9cf0f1078680854712d55c4a22dcbfc17d29
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22781


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
parent 753e344f

module/bdev/nvme/bdev_nvme_rpc.c

+1 −0
Original line number Diff line number Diff line
@@ -2373,6 +2373,7 @@ rpc_bdev_nvme_set_multipath_policy(struct spdk_jsonrpc_request *request, 
	}



	ctx->req.rr_min_io = UINT32_MAX;

	ctx->req.selector = BDEV_NVME_MP_SELECTOR_ROUND_ROBIN;



	if (spdk_json_decode_object(params, rpc_set_multipath_policy_decoders,

				    SPDK_COUNTOF(rpc_set_multipath_policy_decoders),