Commit 4c4e2b4d authored by Changpeng Liu's avatar Changpeng Liu Committed by Daniel Verkamp
Browse files

bdev/nvme: update NS bdevs after NS attribute notice event 



Change-Id: I7c42696c09a3a4d35e0339ecfdf68c256c935a76
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.gerrithub.io/415117


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarSeth Howell <seth.howell5141@gmail.com>
Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent ddb3583b

lib/bdev/nvme/bdev_nvme.c

+51 −0
Original line number Diff line number Diff line
@@ -856,6 +856,55 @@ timeout_cb(void *cb_arg, struct spdk_nvme_ctrlr *ctrlr, 
	}

}



static void

nvme_ctrlr_deactivate_bdev(struct nvme_bdev *bdev)

{

	spdk_bdev_unregister(&bdev->disk, NULL, NULL);

	bdev->active = false;

}



static void

nvme_ctrlr_update_ns_bdevs(struct nvme_ctrlr *nvme_ctrlr)

{

	struct spdk_nvme_ctrlr	*ctrlr = nvme_ctrlr->ctrlr;

	uint32_t		i;

	struct nvme_bdev	*bdev;



	for (i = 0; i < nvme_ctrlr->num_ns; i++) {

		uint32_t	nsid = i + 1;



		bdev = &nvme_ctrlr->bdevs[i];

		if (!bdev->active && spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid)) {

			SPDK_NOTICELOG("NSID %u to be added\n", nsid);

			nvme_ctrlr_create_bdev(nvme_ctrlr, nsid);

		}



		if (bdev->active && !spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid)) {

			SPDK_NOTICELOG("NSID %u Bdev %s is removed\n", nsid, bdev->disk.name);

			nvme_ctrlr_deactivate_bdev(bdev);

		}

	}



}



static void

aer_cb(void *arg, const struct spdk_nvme_cpl *cpl)

{

	struct nvme_ctrlr *nvme_ctrlr		= arg;

	union spdk_nvme_async_event_completion	event;



	if (spdk_nvme_cpl_is_error(cpl)) {

		SPDK_WARNLOG("AER request execute failed");

		return;

	}



	event.raw = cpl->cdw0;

	if ((event.bits.async_event_type == SPDK_NVME_ASYNC_EVENT_TYPE_NOTICE) &&

	    (event.bits.async_event_info == SPDK_NVME_ASYNC_EVENT_NS_ATTR_CHANGED)) {

		nvme_ctrlr_update_ns_bdevs(nvme_ctrlr);

	}

}



static int

create_ctrlr(struct spdk_nvme_ctrlr *ctrlr,

	     const char *name,
@@ -901,6 +950,8 @@ create_ctrlr(struct spdk_nvme_ctrlr *ctrlr, 
				timeout_cb, NULL);

	}



	spdk_nvme_ctrlr_register_aer_callback(ctrlr, aer_cb, nvme_ctrlr);



	return 0;

}