Commit 49e04009 authored by Darek Stojaczyk's avatar Darek Stojaczyk Committed by Changpeng Liu
Browse files

vhost: check for strdup failure 



We could silently fail the allocation and probably
segfault soon after.

Change-Id: I3851b78500fcb3f64a06bdf0c0e5566d6148cbee
Signed-off-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/447026


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 55656fb1

lib/vhost/vhost.c

+8 −0
Original line number Diff line number Diff line
@@ -753,6 +753,14 @@ spdk_vhost_dev_register(struct spdk_vhost_dev *vdev, const char *name, const cha 


	vdev->name = strdup(name);

	vdev->path = strdup(path);

	if (vdev->name == NULL || vdev->path == NULL) {

		free(vdev->name);

		free(vdev->path);

		rte_vhost_driver_unregister(path);

		rc = -EIO;

		goto out;

	}



	vdev->cpumask = cpumask;

	vdev->registered = true;

	vdev->backend = backend;