Commit 48e6cc6f authored by Michal Berger's avatar Michal Berger Committed by Tomasz Zawadzki
Browse files

Revert "test/common: Indicate failure when run_test()'s cmd returns es != 0" 

This change negatively affects failure detection in all the suites
which don't adhere to:

"For similar scenarios, we need to force errexit into action by
explicitly returning from the run_test() when the command it executes
fails".

For instance, wrapper functions which execute unittests got affected
by it. See for instance: https://github.com/spdk/spdk/issues/3451



This would require some bulky refactor which is simply not worth the
effort, it's better to drop this change altogether.

This reverts commit e5160883.

Change-Id: Ifa13e194f498e30a52dc062a5e9f65e169c0bfe8
Signed-off-by: default avatarMichal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24296


Bypass-Merge-Requirements: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent b8378f94

test/common/autotest_common.sh

+2 −4
Original line number Diff line number Diff line
@@ -1103,7 +1103,7 @@ function run_test() { 
	fi



	xtrace_disable

	local test_name="$1" pid es=0

	local test_name="$1" pid

	shift



	if [ -n "${test_domain:-}" ]; then
@@ -1120,7 +1120,7 @@ function run_test() { 
	echo "START TEST $test_name"

	echo "************************************"

	xtrace_restore

	time "$@" || es=$?

	time "$@"

	xtrace_disable

	echo "************************************"

	echo "END TEST $test_name"
@@ -1138,8 +1138,6 @@ function run_test() { 
		echo "$test_domain $test_name" >> $output_dir/test_completions.txt

	fi

	xtrace_restore



	return "$es"

}



function skip_run_test_with_warning() {