Commit 47a6578e authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Ben Walker
Browse files

lib/event: calculate last_stats in event framework 



Rather than to rely on schedulers to access and modify
last_stats values over multiple scheduling periods, move that
operation to event framework.

Providing this to the schedulers in generic manner is better
than enforcing that each scheduler has to keep track of this
data on their own.

Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Icaf3b4af80d86fafaddf328fd230db9743d21ab5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7971


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 005b22d2

lib/event/reactor.c

+7 −3
Original line number Diff line number Diff line
@@ -674,11 +674,18 @@ static void 
_init_thread_stats(struct spdk_reactor *reactor, struct spdk_lw_thread *lw_thread)

{

	struct spdk_thread *thread = spdk_thread_get_from_ctx(lw_thread);

	struct spdk_thread_stats last_stats;



	/* Save last stats before replacing them. */

	last_stats = lw_thread->current_stats;



	lw_thread->lcore = reactor->lcore;



	spdk_set_thread(thread);

	spdk_thread_get_stats(&lw_thread->current_stats);

	spdk_set_thread(NULL);



	lw_thread->last_stats = last_stats;

}



static void
@@ -1170,7 +1177,6 @@ _reactor_schedule_thread(struct spdk_thread *thread) 
{

	uint32_t core;

	struct spdk_lw_thread *lw_thread;

	struct spdk_thread_stats last_stats;

	struct spdk_event *evt = NULL;

	struct spdk_cpuset *cpumask;

	uint32_t i;
@@ -1184,9 +1190,7 @@ _reactor_schedule_thread(struct spdk_thread *thread) 
	lw_thread = spdk_thread_get_ctx(thread);

	assert(lw_thread != NULL);

	core = lw_thread->lcore;

	last_stats = lw_thread->last_stats;

	memset(lw_thread, 0, sizeof(*lw_thread));

	lw_thread->last_stats = last_stats;



	if (current_lcore != SPDK_ENV_LCORE_ID_ANY) {

		local_reactor = spdk_reactor_get(current_lcore);

lib/event/scheduler_dynamic.c

+0 −3
Original line number Diff line number Diff line
@@ -71,9 +71,6 @@ _get_thread_load(struct spdk_lw_thread *lw_thread) 
	busy = lw_thread->current_stats.busy_tsc - lw_thread->last_stats.busy_tsc;

	idle = lw_thread->current_stats.idle_tsc - lw_thread->last_stats.idle_tsc;



	lw_thread->last_stats.busy_tsc = lw_thread->current_stats.busy_tsc;

	lw_thread->last_stats.idle_tsc = lw_thread->current_stats.idle_tsc;



	if (busy == 0) {

		/* No work was done, exit before possible division by 0. */

		return 0;