Commit 473d5a8f authored by Darek Stojaczyk's avatar Darek Stojaczyk Committed by Jim Harris
Browse files

iscsi: don't store paddr in pdu buffers 



The physical addresses in iSCSI are completely unused
as iSCSI does not perform any DMA on its own.

Change-Id: I350037b708a9f36f423e6ca6f7c822d8b6b95116
Signed-off-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/443482


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 1dc9e702

lib/iscsi/iscsi_subsystem.c

+0 −10
Original line number Diff line number Diff line
@@ -130,21 +130,11 @@ spdk_mobj_ctor(struct spdk_mempool *mp, __attribute__((unused)) void *arg, 
	       void *_m, __attribute__((unused)) unsigned i)

{

	struct spdk_mobj *m = _m;

	uint64_t *phys_addr;

	ptrdiff_t off;



	m->mp = mp;

	m->buf = (uint8_t *)m + sizeof(struct spdk_mobj);

	m->buf = (void *)((unsigned long)((uint8_t *)m->buf + ISCSI_DATA_BUFFER_ALIGNMENT) &

			  ~ISCSI_DATA_BUFFER_MASK);

	off = (uint64_t)(uint8_t *)m->buf - (uint64_t)(uint8_t *)m;



	/*

	 * we store the physical address in a 64bit unsigned integer

	 * right before the 512B aligned buffer area.

	 */

	phys_addr = (uint64_t *)m->buf - 1;

	*phys_addr = spdk_vtophys(m, NULL) + off;

}



#define NUM_PDU_PER_CONNECTION(iscsi)	(2 * (iscsi->MaxQueueDepth + MAX_LARGE_DATAIN_PER_CONNECTION + 8))