Commit 4544a8b2 authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

nvme/rdma: fix incorrect NQN strncpy() usage 



Make sure the entire NQN field is zero-padded, rather than using
strlen() on the input.

Change-Id: Icee68bd033feed057813beeb30cec102ed90840e
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
parent cf3fb7bb

lib/nvme/nvme_rdma.c

+2 −2
Original line number Diff line number Diff line
@@ -857,8 +857,8 @@ nvme_rdma_qpair_fabric_connect(struct nvme_rdma_qpair *rqpair) 


	strncpy((char *)&nvmf_data->hostid, (char *)NVME_HOST_ID_DEFAULT,

		strlen((char *)NVME_HOST_ID_DEFAULT));

	strncpy((char *)&nvmf_data->hostnqn, (char *)NVME_HOST_NQN, strlen((char *)NVME_HOST_NQN));

	strncpy((char *)&nvmf_data->subnqn, rctrlr->info.nqn, strlen(rctrlr->info.nqn));

	strncpy((char *)nvmf_data->hostnqn, NVME_HOST_NQN, sizeof(nvmf_data->hostnqn));

	strncpy((char *)nvmf_data->subnqn, rctrlr->info.nqn, sizeof(nvmf_data->subnqn));



	rc = spdk_nvme_ctrlr_cmd_admin_raw(ctrlr,

					   (struct spdk_nvme_cmd *)&cmd,