Commit 44fad16e authored by Pawel Piatek's avatar Pawel Piatek Committed by Tomasz Zawadzki
Browse files

test/nvme_perf: remove preconditioning 



This script is designed in a way to call it for one
use case. Executing preconditioning each time we call
this script would be an overkill. Additionally, we
plan to add support for lvol bdevs, so we would need
to add special protection to avoid erase of lvol data
from disks by preconditioning.

Signed-off-by: default avatarPawel Piatek <pawelx.piatek@intel.com>
Change-Id: I5c2dd457d995c2743bf2748dc835e65dbff7cdcc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18412


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarMichal Berger <michal.berger@intel.com>
parent 0b5e1e66

test/nvme/perf/README.md

+0 −5
Original line number Diff line number Diff line
@@ -92,11 +92,6 @@ Create the specified number of clones of a job. 


Specifies how many times run each workload. End results are averages of these workloads



#### --no-preconditioning



By default disks are preconditioned before test using fio with parameters: size=100%, loops=2, bs=1M, w=write,

iodepth=32, ioengine=spdk. It can be skipped when this option is set.



#### "--no-io-scaling"



For SPDK fio plugin iodepth is multiplied by number of devices. When this option is set this multiplication will be disabled.

test/nvme/perf/common.sh

+0 −24
Original line number Diff line number Diff line
@@ -320,30 +320,6 @@ function create_fio_config() { 
	cat $testdir/config.fio

}



function preconditioning() {

	local dev_name=""

	local filename=""

	local nvme_list



	HUGEMEM=8192 $rootdir/scripts/setup.sh

	cp $testdir/config.fio.tmp $testdir/config.fio

	echo "[Preconditioning]" >> $testdir/config.fio



	# Generate filename argument for FIO.

	# We only want to target NVMes not bound to nvme driver.

	# If they're still bound to nvme that means they were skipped by

	# setup.sh on purpose.

	nvme_list=$(get_disks nvme)

	for nvme in $nvme_list; do

		dev_name='trtype=PCIe traddr='${nvme//:/.}' ns=1'

		filename+=$(printf %s":" "$dev_name")

	done

	echo "** Preconditioning disks, this can take a while, depending on the size of disks."

	run_spdk_nvme_fio "spdk-plugin-nvme" --filename="$filename" --size=100% --loops=2 --bs=1M \

		--rw=write --iodepth=32 --output-format=normal

	rm -f $testdir/config.fio

}



function bc() {

	$(type -P bc) -l <<< "scale=3; $1"

}

test/nvme/perf/run_perf.sh

+0 −7
Original line number Diff line number Diff line
@@ -46,7 +46,6 @@ BDEV_POOL="" 
DISKNO="ALL"

CPUS_ALLOWED=1

NOIOSCALING=false

PRECONDITIONING=true

CPUFREQ=""

PERFTOP=false

DPDKMEM=false
@@ -107,7 +106,6 @@ function usage() { 
	echo "                            If =ALL then test on all found disk. [default=$DISKNO]"

	echo "    --cpu-allowed=INT/PATH  Comma-separated list of CPU cores used to run the workload. Ranges allowed."

	echo "                            Can also point to a file containing list of CPUs. [default=$CPUS_ALLOWED]"

	echo "    --no-preconditioning    Skip preconditioning"

	echo "    --no-io-scaling         Do not scale iodepth for each device in SPDK fio plugin. [default=$NOIOSCALING]"

	echo "    --cpu-frequency=INT     Run tests with CPUs set to a desired frequency. 'intel_pstate=disable' must be set in"

	echo "                            GRUB options. You can use 'cpupower frequency-info' and 'cpupower frequency-set' to"
@@ -167,7 +165,6 @@ while getopts 'h-:' optchar; do 
						CPUS_ALLOWED=$(cat "$CPUS_ALLOWED")

					fi

					;;

				no-preconditioning) PRECONDITIONING=false ;;

				no-io-scaling) NOIOSCALING=true ;;

				cpu-frequency=*) CPUFREQ="${OPTARG#*=}" ;;

				perftop) PERFTOP=true ;;
@@ -225,10 +222,6 @@ CORES=$(get_cores "$CPUS_ALLOWED") 
NO_CORES_ARRAY=($CORES)

NO_CORES=${#NO_CORES_ARRAY[@]}



if $PRECONDITIONING; then

	preconditioning

fi



if [[ "$PLUGIN" =~ "kernel" || "$PLUGIN" =~ "xnvme" ]]; then

	$rootdir/scripts/setup.sh reset

	fio_ioengine_opt="${KERNEL_ENGINES[$PLUGIN]}"