Commit 44c6faac authored by Changpeng Liu's avatar Changpeng Liu Committed by Jim Harris
Browse files

nvme: move hardcoded keep alive timeout value to macro definition 



Change-Id: I27ab6ea046ade42f941b323cea5f104bb952c53d
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.gerrithub.io/c/441994


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarArshad Hussain <arshad.super@gmail.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 81faea1b

lib/nvme/nvme_ctrlr.c

+1 −1
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ spdk_nvme_ctrlr_get_default_ctrlr_opts(struct spdk_nvme_ctrlr_opts *opts, size_t 
	}



	if (FIELD_OK(keep_alive_timeout_ms)) {

		opts->keep_alive_timeout_ms = 10 * 1000;

		opts->keep_alive_timeout_ms = MIN_KEEP_ALIVE_TIMEOUT_IN_MS;

	}



	if (FIELD_OK(io_queue_size)) {

lib/nvme/nvme_internal.h

+2 −0
Original line number Diff line number Diff line
@@ -135,6 +135,8 @@ extern pid_t g_spdk_nvme_pid; 
#define DEFAULT_ADMIN_QUEUE_REQUESTS	(32)

#define DEFAULT_IO_QUEUE_REQUESTS	(512)



#define MIN_KEEP_ALIVE_TIMEOUT_IN_MS	(10000)



/* We want to fit submission and completion rings each in a single 2MB

 * hugepage to ensure physical address contiguity.

 */