Commit 4390e4ee authored May 15, 2025 by Jim Harris Committed by Tomasz Zawadzki May 20, 2025

rocksdb: deprecate this plugin



Since the blobfs library is being deprecated, deprecate the rocksdb
plugin too which depends on it.

Refer to the blobfs deprecation commit message for additional details.

Signed-off-by: Jim Harris <jim.harris@nvidia.com>
Change-Id: I8bda2680a868c18b87b0991eedde774b1b9bd982
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/25945


Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: Konrad Sztyber <ksztyber@nvidia.com>
Community-CI: Mellanox Build Bot

parent e939a432

deprecation.md

+6 −0

Original line number	Diff line number	Diff line
		@@ -64,3 +64,9 @@ the module will emit deprecation warnings when usage is detected.
		This entire blobfs library is deprecated and will be removed in 25.09 release.
		All functions in this library are effectively deprecated, but only these two
		are officially marked as such to ensure the library's deprecation is noticed.

		### rocksdb

		The SPDK rocksdb plugin is deprecated and will be removed in 25.09 release.
		This C++ plugin exports no public APIs, so none are listed here, but
		the pluging will emit deprecation warnings when usage is detected.

lib/rocksdb/env_spdk.cc

+4 −0

Original line number	Diff line number	Diff line
		@@ -683,12 +683,16 @@ initialize_spdk(void *arg)

		}

		SPDK_LOG_DEPRECATION_REGISTER(rocksdb_plugin, "rocksdb plugin", "v25.09", 0)

		SpdkEnv::SpdkEnv(Env *base_env, const std::string &dir, const std::string &conf,
		const std::string &bdev, uint64_t cache_size_in_mb)
		: EnvWrapper(base_env), mDirectory(dir), mConfig(conf), mBdev(bdev)
		{
		struct spdk_app_opts *opts = new struct spdk_app_opts;

		SPDK_LOG_DEPRECATED(rocksdb_plugin);

		spdk_app_opts_init(opts, sizeof(*opts));
		opts->name = "rocksdb";
		opts->json_config_file = mConfig.c_str();