Commit 4224fc34 authored by Marcin Spiewak's avatar Marcin Spiewak Committed by Tomasz Zawadzki
Browse files

lib/nvme: add mutex before submit admin request 



In nvme_ctrlr_cmd_identify(), the call to
nvme_ctrlr_submit_admin_request() shall be
preceeded by taking ctrlr->ctrlr_lock mutex,
like in other places in the code.

Change-Id: Ibd4ef2aa02d906dac853e537df9a837974b6c358
Signed-off-by: default avatarMarcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22419


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
parent b538e6ef

lib/nvme/nvme_ctrlr_cmd.c

+7 −1
Original line number Diff line number Diff line
@@ -152,11 +152,14 @@ nvme_ctrlr_cmd_identify(struct spdk_nvme_ctrlr *ctrlr, uint8_t cns, uint16_t cnt 
{

	struct nvme_request *req;

	struct spdk_nvme_cmd *cmd;

	int		     rc;



	nvme_robust_mutex_lock(&ctrlr->ctrlr_lock);

	req = nvme_allocate_request_user_copy(ctrlr->adminq,

					      payload, payload_size,

					      cb_fn, cb_arg, false);

	if (req == NULL) {

		nvme_robust_mutex_unlock(&ctrlr->ctrlr_lock);

		return -ENOMEM;

	}
@@ -167,7 +170,10 @@ nvme_ctrlr_cmd_identify(struct spdk_nvme_ctrlr *ctrlr, uint8_t cns, uint16_t cnt 
	cmd->cdw11_bits.identify.csi = csi;

	cmd->nsid = nsid;



	return nvme_ctrlr_submit_admin_request(ctrlr, req);

	rc = nvme_ctrlr_submit_admin_request(ctrlr, req);



	nvme_robust_mutex_unlock(&ctrlr->ctrlr_lock);

	return rc;

}



int