Commit 4214803c authored by Mateusz Kozlowski's avatar Mateusz Kozlowski Committed by Ben Walker
Browse files

lib/ftl: Add public get chunk info admin command 



The patch also changes, so the command calculates the needed
chunk offset based on PPA, instead of relying on the user to
provide one.

Signed-off-by: default avatarMateusz Kozlowski <mateusz.kozlowski@intel.com>
Change-Id: Ic4eec1b86ded4eb71de860015403294ed0c8c266
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455973


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent baa06190

lib/ftl/ftl_core.h

+3 −0
Original line number Diff line number Diff line
@@ -249,6 +249,9 @@ size_t ftl_head_md_num_lbks(const struct spdk_ftl_dev *dev); 
int	ftl_restore_md(struct spdk_ftl_dev *dev, ftl_restore_fn cb);

int	ftl_restore_device(struct ftl_restore *restore, ftl_restore_fn cb);

int	ftl_band_set_direct_access(struct ftl_band *band, bool access);

int	ftl_retrieve_chunk_info(struct spdk_ftl_dev *dev, struct ftl_ppa ppa,

				struct spdk_ocssd_chunk_information_entry *info,

				unsigned int num_entries);



#define ftl_to_ppa(addr) \

	(struct ftl_ppa) { .ppa = (uint64_t)(addr) }

lib/ftl/ftl_init.c

+12 −11
Original line number Diff line number Diff line
@@ -187,13 +187,15 @@ out: 
	return rc;

}



static int

ftl_retrieve_bbt_page(struct spdk_ftl_dev *dev, uint64_t offset,

int

ftl_retrieve_chunk_info(struct spdk_ftl_dev *dev, struct ftl_ppa ppa,

			struct spdk_ocssd_chunk_information_entry *info,

			unsigned int num_entries)

{

	volatile struct ftl_admin_cmpl cmpl = {};

	uint32_t nsid = spdk_nvme_ns_get_id(dev->ns);

	uint64_t offset = (ppa.grp * dev->geo.num_pu + ppa.pu) *

			  dev->geo.num_chk + ppa.chk;



	if (spdk_nvme_ctrlr_cmd_get_log_page(dev->ctrlr, SPDK_OCSSD_LOG_CHUNK_INFO, nsid,

					     info, num_entries * sizeof(*info),
@@ -216,20 +218,19 @@ ftl_retrieve_bbt_page(struct spdk_ftl_dev *dev, uint64_t offset, 
}



static int

ftl_retrieve_bbt(struct spdk_ftl_dev *dev, const struct ftl_punit *punit,

ftl_retrieve_punit_chunk_info(struct spdk_ftl_dev *dev, const struct ftl_punit *punit,

			      struct spdk_ocssd_chunk_information_entry *info)

{

	uint32_t i = 0;

	unsigned int num_entries = PAGE_SIZE / sizeof(*info);

	uint64_t off = (punit->start_ppa.grp * dev->geo.num_pu + punit->start_ppa.pu) *

		       dev->geo.num_chk;

	struct ftl_ppa chunk_ppa = punit->start_ppa;



	for (i = 0; i < dev->geo.num_chk; i += num_entries) {

	for (i = 0; i < dev->geo.num_chk; i += num_entries, chunk_ppa.chk += num_entries) {

		if (num_entries > dev->geo.num_chk - i) {

			num_entries = dev->geo.num_chk - i;

		}



		if (ftl_retrieve_bbt_page(dev, off + i, &info[i], num_entries)) {

		if (ftl_retrieve_chunk_info(dev, chunk_ppa, &info[i], num_entries)) {

			return -1;

		}

	}
@@ -332,7 +333,7 @@ ftl_dev_init_bands(struct spdk_ftl_dev *dev) 
	for (i = 0; i < ftl_dev_num_punits(dev); ++i) {

		punit = &dev->punits[i];



		rc = ftl_retrieve_bbt(dev, punit, info);

		rc = ftl_retrieve_punit_chunk_info(dev, punit, info);

		if (rc) {

			SPDK_ERRLOG("Failed to retrieve bbt for @ppa: %s [%lu]\n",

				    ftl_ppa2str(punit->start_ppa, buf, sizeof(buf)),