Commit 415abe87 authored by Dayu Liu's avatar Dayu Liu Committed by Tomasz Zawadzki
Browse files

check_format: fix pattern error of regular expression 



In a few tools or languages, slash(/) is maybe a delimiter by default in regex.
An unescaped delimiter must be escaped with a backslash (\).
Otherwise the pattern of regular expression will be error
when delimiter is slash(/) in a few special environment, i.e. in MinGW32 git bash.

Signed-off-by: default avatarDayu Liu <liu.dayu@zte.com.cn>
Change-Id: I73b556416b98e135eb240078dcc68f80e08c5e74
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2488


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent ade2aa25

scripts/check_format.sh

+4 −4
Original line number Diff line number Diff line
@@ -122,11 +122,11 @@ fi 


echo -n "Checking comment style..."



git grep --line-number -e '/[*][^ *-]' -- '*.[ch]' > comment.log || true

git grep --line-number -e '[^ ][*]/' -- '*.[ch]' ':!lib/rte_vhost*/*' >> comment.log || true

git grep --line-number -e '\/[*][^ *-]' -- '*.[ch]' > comment.log || true

git grep --line-number -e '[^ ][*]\/' -- '*.[ch]' ':!lib/rte_vhost*/*' >> comment.log || true

git grep --line-number -e '^[*]' -- '*.[ch]' >> comment.log || true

git grep --line-number -e '\s//' -- '*.[ch]' >> comment.log || true

git grep --line-number -e '^//' -- '*.[ch]' >> comment.log || true

git grep --line-number -e '\s\/\/' -- '*.[ch]' >> comment.log || true

git grep --line-number -e '^\/\/' -- '*.[ch]' >> comment.log || true



if [ -s comment.log ]; then

	echo " Incorrect comment formatting detected"