Commit 412d89cd authored Sep 11, 2018 by Rami Rosen Committed by Jim Harris Sep 11, 2018

ioat: change return type of spdk_ioat_detach() to be void



The method spdk_ioat_detach() never fails. This patch changes its
return type to be void instead of int.

Change-Id: I6f5bda9ab330c02ae0535bed8b78d416c7b1e264
Signed-off-by: Rami Rosen <ramirose@gmail.com>
Reviewed-on: https://review.gerrithub.io/425252


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Seth Howell <seth.howell5141@gmail.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

parent 55014ddf

include/spdk/ioat.h

+2 −4

Original line number	Diff line number	Diff line
		@@ -104,10 +104,8 @@ int spdk_ioat_probe(void *cb_ctx, spdk_ioat_probe_cb probe_cb, spdk_ioat_attach_
		* Detach specified device returned by spdk_ioat_probe() from the I/OAT driver.
		*
		* \param ioat I/OAT channel to detach from the driver.
		*
		* \return 0 on success.
		*/
		int spdk_ioat_detach(struct spdk_ioat_chan *ioat);
		void spdk_ioat_detach(struct spdk_ioat_chan *ioat);

		/**
		* Submit a DMA engine memory copy request.

lib/ioat/ioat.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -568,7 +568,7 @@ spdk_ioat_probe(void *cb_ctx, spdk_ioat_probe_cb probe_cb, spdk_ioat_attach_cb a
		return rc;
		}

		int
		void
		spdk_ioat_detach(struct spdk_ioat_chan *ioat)
		{
		struct ioat_driver *driver = &g_ioat_driver;
		@@ -582,8 +582,6 @@ spdk_ioat_detach(struct spdk_ioat_chan *ioat)

		ioat_channel_destruct(ioat);
		free(ioat);

		return 0;
		}

		#define _2MB_PAGE(ptr) ((ptr) & ~(0x200000 - 1))