Commit 3f73c08e authored by Tomasz Zawadzki's avatar Tomasz Zawadzki
Browse files

deprecation: update status for SPDK 23.09 



Deprecation notices required updates to the current state:
- PMDK support (pmem bdev) was removed in SPDK 23.05 already
- libreduce still supports libpmem (not to be confused with libpmemblk),
so the configure notice was removed
- VTune shall no longer be removed, there are outstanding patches in review
- spdk_nvmf_qpair_disconnect() was not modified in SPDK 23.09, move it to
  24.01

Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20120

 (master)

(cherry picked from commit c0d67439)
Change-Id: I8b94705b103308d88e3a75d34533bbc94a527451
Signed-off-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20156


Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent d1d3a5ea

configure

+0 −2
Original line number Diff line number Diff line
@@ -790,7 +790,6 @@ else 
fi



if [ "${CONFIG[VTUNE]}" = "y" ]; then

	echo "WARNING: VTune support is deprecated."

	if [ -z "${CONFIG[VTUNE_DIR]}" ]; then

		echo "When VTune is enabled, you must specify the VTune directory using --with-vtune=path"

		exit 1
@@ -941,7 +940,6 @@ function mlx5_build() { 
}



if [[ "${CONFIG[VBDEV_COMPRESS]}" = "y" ]]; then

	echo "WARNING: PMDK - Persistent device support with bdev_compress is deprecated."

	if ! echo -e '#include <libpmem.h>\nint main(void) { return 0; }\n' \

		| "${BUILD_CMD[@]}" -lpmem - 2> /dev/null; then

		echo "--with-vbdev-compress requires libpmem."

deprecation.md

+1 −12
Original line number Diff line number Diff line
@@ -19,23 +19,12 @@ The tags can be matched with the level 4 headers below. 


## Deprecation Notices



### PMDK



PMDK is no longer supported and integrations with it in SPDK are now deprecated, and will be removed in SPDK 23.05.

Please see: [UPDATE ON PMDK AND OUR LONG TERM SUPPORT STRATEGY](https://pmem.io/blog/2022/11/update-on-pmdk-and-our-long-term-support-strategy/).



### VTune



#### `vtune_support`



VTune integration is in now deprecated and will be removed in the 23.09 release.



### nvmf



#### `spdk_nvmf_qpair_disconnect`



Parameters `cb_fn` and `ctx` of `spdk_nvmf_qpair_disconnect` API are deprecated. These parameters

will be removed in 23.09 release.

will be removed in 24.01 release.



#### `nvmf_get_subsystems`

include/spdk/nvmf.h

+2 −2
Original line number Diff line number Diff line
@@ -300,8 +300,8 @@ typedef void (*nvmf_qpair_disconnect_cb)(void *ctx); 
 * Disconnect an NVMe-oF qpair

 *

 * \param qpair The NVMe-oF qpair to disconnect.

 * \param cb_fn Deprecated, will be removed in v23.09. The function to call upon completion of the disconnect.

 * \param ctx Deprecated, will be removed in v23.09. The context to pass to the callback function.

 * \param cb_fn Deprecated, will be removed in v24.01. The function to call upon completion of the disconnect.

 * \param ctx Deprecated, will be removed in v24.01. The context to pass to the callback function.

 *

 * \return 0 upon success.

 * \return -ENOMEM if the function specific context could not be allocated.

lib/bdev/bdev.c

+0 −3
Original line number Diff line number Diff line
@@ -75,8 +75,6 @@ int __itt_init_ittlib(const char *, __itt_group_id); 
static void log_already_claimed(enum spdk_log_level level, const int line, const char *func,

				const char *detail, struct spdk_bdev *bdev);



SPDK_LOG_DEPRECATION_REGISTER(vtune_support, "Intel(R) VTune integration", "v23.09", 0);



static const char *qos_rpc_type[] = {"rw_ios_per_sec",

				     "rw_mbytes_per_sec", "r_mbytes_per_sec", "w_mbytes_per_sec"

				    };
@@ -2119,7 +2117,6 @@ spdk_bdev_initialize(spdk_bdev_init_cb cb_fn, void *cb_arg) 
	}



#ifdef SPDK_CONFIG_VTUNE

	SPDK_LOG_DEPRECATED(vtune_support);

	g_bdev_mgr.domain = __itt_domain_create("spdk_bdev");

#endif

lib/nvmf/nvmf.c

+1 −1
Original line number Diff line number Diff line
@@ -1248,7 +1248,7 @@ _nvmf_qpair_disconnect_msg(void *ctx) 
	free(ctx);

}



SPDK_LOG_DEPRECATION_REGISTER(spdk_nvmf_qpair_disconnect, "cb_fn and ctx are deprecated", "v23.09",

SPDK_LOG_DEPRECATION_REGISTER(spdk_nvmf_qpair_disconnect, "cb_fn and ctx are deprecated", "v24.01",

			      0);



int