Commit 3ef7f2b7 authored Nov 27, 2019 by Changpeng Liu Committed by Tomasz Zawadzki Dec 06, 2019

nvmf: remove special xfer check for get/set features admin commands



There are some new features defined in NVMe 1.4 specification also need
the data buffer, but for now we only listed 3 features, we will check
the data length field anyway, so this piece of code can be removed.

Change-Id: I22204cf53077073434bb0ed73693bcf72883f084
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/475953


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent bc13d022

lib/nvmf/nvmf_internal.h

+0 −14

Original line number	Diff line number	Diff line
		@@ -462,20 +462,6 @@ spdk_nvmf_req_get_xfer(struct spdk_nvmf_request *req) {
		} else
		{
		xfer = spdk_nvme_opc_get_data_transfer(cmd->opc);

		/* Some admin commands are special cases */
		if ((req->qpair->qid == 0) &&
		((cmd->opc == SPDK_NVME_OPC_GET_FEATURES) \|\|
		(cmd->opc == SPDK_NVME_OPC_SET_FEATURES))) {
		switch (cmd->cdw10 & 0xff) {
		case SPDK_NVME_FEAT_LBA_RANGE_TYPE:
		case SPDK_NVME_FEAT_AUTONOMOUS_POWER_STATE_TRANSITION:
		case SPDK_NVME_FEAT_HOST_IDENTIFIER:
		break;
		default:
		xfer = SPDK_NVME_DATA_NONE;
		}
		}
		}

		if (xfer == SPDK_NVME_DATA_NONE)