Commit 3e2e0e8b authored by Pawel Baldysiak's avatar Pawel Baldysiak Committed by Tomasz Zawadzki
Browse files

python/cli/nvmf: Add option to set all passthru admin cmds at once 



Add additional "all" parameter as an option to list of passthru
admin cmds.
This parameter would enable handlers for all supported passthru cmds.

Change-Id: I271cc45e15fe1876fa4e6ff5985dfa581035171e
Signed-off-by: default avatarPawel Baldysiak <pawel.baldysiak@dell.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26237


Reviewed-by: default avatarAmit Engel <amit.engel@dell.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
parent 1766296c

python/spdk/cli/nvmf.py

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ def add_parser(subparsers): 
    when the controller has a single namespace that is an NVMe bdev (deprecated)""", action='store_true')

    p.add_argument('-p', '--passthru-admin-cmds', help="""Comma-separated list of admin commands to be passthru

                   when the controller has a single namespace that is an NVMe bdev.

                   Available options are: identify_ctrlr""", type=lambda d: d.split(','))

                   Available options are: all, identify_ctrlr""", type=lambda d: d.split(','))

    p.add_argument('-m', '--poll-groups-mask', help='Set cpumask for NVMf poll groups (optional)', type=str)

    p.add_argument('-d', '--discovery-filter', help="""Set discovery filter (optional), possible values are: `match_any` (default) or

         comma separated values: `transport`, `address`, `svcid`""", type=str)

python/spdk/rpc/nvmf.py

+5 −1
Original line number Diff line number Diff line
@@ -36,8 +36,12 @@ def nvmf_set_config(client, 
        True or False

    """

    params = {}

    all_admin_cmd_passthru = ('identify_ctrlr')



    if passthru_admin_cmds:

        if 'all' in passthru_admin_cmds:

            params['admin_cmd_passthru'] = {cmd: True for cmd in all_admin_cmd_passthru}

        else:

            params['admin_cmd_passthru'] = {cmd: True for cmd in passthru_admin_cmds}

    if poll_groups_mask:

        params['poll_groups_mask'] = poll_groups_mask