Commit 3bbfbb5b authored by paul luse's avatar paul luse Committed by Jim Harris
Browse files

lib/idxd: update some func params for consistency 



Was using "dst" in some cases and "crc_dst" in others for crc32c
related calls.  Update them to always use crc_dst

Signed-off-by: default avatarpaul luse <paul.e.luse@intel.com>
Change-Id: Icf200f1734c64c29881f23b02b8d12bad81b3ca0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8186


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarZiye Yang <ziye.yang@intel.com>
parent 10808e45

include/spdk/idxd.h

+2 −2
Original line number Diff line number Diff line
@@ -352,7 +352,7 @@ int spdk_idxd_batch_prep_crc32c(struct spdk_idxd_io_channel *chan, struct idxd_b 
 * by writing to the proper device portal.

 *

 * \param chan IDXD channel to submit request.

 * \param dst Resulting calculation.

 * \param crc_dst Resulting calculation.

 * \param src Source virtual address.

 * \param seed Four byte CRC-32C seed value.

 * \param nbytes Number of bytes to calculate on.
@@ -362,7 +362,7 @@ int spdk_idxd_batch_prep_crc32c(struct spdk_idxd_io_channel *chan, struct idxd_b 
 *

 * \return 0 on success, negative errno on failure.

 */

int spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *dst, void *src,

int spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *crc_dst, void *src,

			    uint32_t seed, uint64_t nbytes,

			    spdk_idxd_req_cb cb_fn, void *cb_arg);

lib/idxd/idxd.c

+2 −2
Original line number Diff line number Diff line
@@ -546,7 +546,7 @@ spdk_idxd_submit_fill(struct spdk_idxd_io_channel *chan, void *dst, uint64_t fil 
}



int

spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *dst, void *src,

spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *crc_dst, void *src,

			uint32_t seed, uint64_t nbytes,

			spdk_idxd_req_cb cb_fn, void *cb_arg)

{
@@ -573,7 +573,7 @@ spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *dst, void * 
	desc->flags &= IDXD_CLEAR_CRC_FLAGS;

	desc->crc32c.seed = seed;

	desc->xfer_size = nbytes;

	comp->crc_dst = dst;

	comp->crc_dst = crc_dst;



	/* Submit operation. */

	movdir64b(chan->portal, desc);