Commit 3b671aa8 authored by Alexey Marchuk's avatar Alexey Marchuk Committed by Konrad Sztyber
Browse files

lib/mlx5: Remove spdk_mlx5_crypto_set_attr 



THe only user was accel_mlx5, this function
is not used anymore

Signed-off-by: default avatarAlexey Marchuk <alexeymar@nvidia.com>
Change-Id: I10b947c175f61cd583c6cd814afb48f7b1cf4b8b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23119


Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
parent 052edaf6

include/spdk_internal/mlx5.h

+0 −15
Original line number Diff line number Diff line
@@ -333,21 +333,6 @@ int spdk_mlx5_crypto_keytag_create(struct spdk_mlx5_crypto_dek_create_attr *attr 
 */

void spdk_mlx5_crypto_keytag_destroy(struct spdk_mlx5_crypto_keytag *keytag);



/**

 * Fills attributes used to register UMR with crypto operation. Deprecated

 *

 * \param attr_out Configured UMR attributes

 * \param keytag Keytag with DEKs

 * \param pd Protection Domain which is going to be used to register UMR. This function will find a DEK in \b keytag with the same PD

 * \param block_size Logical block size

 * \param iv Initialization vector or tweak. Usually that is logical block address

 * \param encrypt_on_tx If set, memory data will be encrypted during TX and wire data will be decrypted during RX. If not set, memory data will be decrypted during TX and wire data will be encrypted during RX.

 * \return 0 on success, negated errno on failure

 */

int spdk_mlx5_crypto_set_attr(struct mlx5dv_crypto_attr *attr_out,

			      struct spdk_mlx5_crypto_keytag *keytag, struct ibv_pd *pd,

			      uint32_t block_size, uint64_t iv, bool encrypt_on_tx);



/**

 * Get Data Encryption Key data

 *

lib/mlx5/mlx5_crypto.c

+0 −54
Original line number Diff line number Diff line
@@ -608,60 +608,6 @@ mlx5_crypto_get_dek_by_pd(struct spdk_mlx5_crypto_keytag *keytag, struct ibv_pd 
	return NULL;

}



int

spdk_mlx5_crypto_set_attr(struct mlx5dv_crypto_attr *attr_out,

			  struct spdk_mlx5_crypto_keytag *keytag, struct ibv_pd *pd,

			  uint32_t block_size, uint64_t iv, bool encrypt_on_tx)

{

	struct spdk_mlx5_crypto_dek_legacy *dek = NULL;

	enum mlx5dv_block_size bs;

	uint32_t i;



	for (i = 0; i < keytag->deks_num; i++) {

		if (keytag->deks_legacy[i].pd == pd) {

			dek = &keytag->deks_legacy[i];

			break;

		}

	}

	if (spdk_unlikely(!dek)) {

		SPDK_ERRLOG("No DEK for pd %p (dev %s)\n", pd, pd->context->device->name);

		return -EINVAL;

	}



	switch (block_size) {

	case 512:

		bs = MLX5DV_BLOCK_SIZE_512;

		break;

	case 520:

		bs = MLX5DV_BLOCK_SIZE_520;

		break;

	case 4048:

		bs = MLX5DV_BLOCK_SIZE_4048;

		break;

	case 4096:

		bs = MLX5DV_BLOCK_SIZE_4096;

		break;

	case 4160:

		bs = MLX5DV_BLOCK_SIZE_4160;

		break;

	default:

		SPDK_ERRLOG("Unsupported block size %u\n", block_size);

		return -EINVAL;

	}



	memset(attr_out, 0, sizeof(*attr_out));

	attr_out->dek = dek->dek_obj;

	attr_out->crypto_standard = MLX5DV_CRYPTO_STANDARD_AES_XTS;

	attr_out->data_unit_size = bs;

	attr_out->encrypt_on_tx = encrypt_on_tx;

	memcpy(attr_out->initial_tweak, &iv, sizeof(iv));

	if (keytag->has_keytag) {

		memcpy(attr_out->keytag, keytag->keytag, sizeof(keytag->keytag));

	}



	return 0;

}



int

spdk_mlx5_crypto_get_dek_data(struct spdk_mlx5_crypto_keytag *keytag, struct ibv_pd *pd,

			      struct spdk_mlx5_crypto_dek_data *data)

lib/mlx5/spdk_mlx5.map

+0 −1
Original line number Diff line number Diff line
@@ -20,7 +20,6 @@ 
    spdk_mlx5_crypto_devs_release;

    spdk_mlx5_crypto_keytag_create;

    spdk_mlx5_crypto_keytag_destroy;

    spdk_mlx5_crypto_set_attr;

    spdk_mlx5_crypto_get_dek_data;

    spdk_mlx5_crypto_devs_allow;