Commit 3b5315e8 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Jim Harris
Browse files

bdev/aio: fix potential stdin fd close 



If strdup fails it jumps to bdev_aio_close which only checks fd against
-1 before proceeding to close, so in this case it can result in stdin
close.

Change-Id: Ic8596a3ab520688d551bd30effa9dd3df43a237b
Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/25788


Reviewed-by: default avatarChangpeng Liu <changpeliu@tencent.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
parent 50e616c5

module/bdev/aio/bdev_aio.c

+1 −0
Original line number Diff line number Diff line
@@ -920,6 +920,7 @@ create_aio_bdev(const char *name, const char *filename, uint32_t block_size, boo 
	}

	fdisk->readonly = readonly;

	fdisk->fallocate = fallocate;

	fdisk->fd = -1;



	fdisk->filename = strdup(filename);

	if (!fdisk->filename) {