Commit 3ac9ba25 authored Jan 31, 2020 by Darek Stojaczyk Committed by Tomasz Zawadzki Feb 06, 2020

env_dpdk: fix potential null dereference



Change-Id: Iff5cfa780506191b3a7fb218c6b5948df2ac16a4
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/523


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

parent a9a472b9

lib/env_dpdk/init.c

+7 −3

Original line number	Diff line number	Diff line
		@@ -271,10 +271,14 @@ spdk_build_eal_cmdline(const struct spdk_env_opts *opts)
		*/
		if (opts->core_mask[0] == '[') {
		char *l_arg = _sprintf_alloc("-l %s", opts->core_mask + 1);

		if (l_arg != NULL) {
		int len = strlen(l_arg);

		if (l_arg[len - 1] == ']') {
		l_arg[len - 1] = '\0';
		}
		}
		args = spdk_push_arg(args, &argcount, l_arg);
		} else {
		args = spdk_push_arg(args, &argcount, _sprintf_alloc("-c %s", opts->core_mask));